Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding algorithm deployment status to Suggestion status #784

Merged
merged 2 commits into from
Sep 21, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Sep 20, 2019

Add status of suggestion deployment to Suggestion CR status


This change is Reviewable

@johnugeorge
Copy link
Member Author

/hold

This won't be required if fix in #785 works

@gaocegege
Copy link
Member

/hold cancel
/lgtm
/approve

It does not work.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f26f7b3 into kubeflow:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants