-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add random forest prior to Bayesian Optimization #81
Conversation
/assign @gaocegege @YujiOshima |
@libbyandhelen Thank you! |
@YujiOshima
shall I put this into the code? |
I do not think we should put the paper citation in the code. Maybe we could maintain a doc about the algorithms that we support and list the citations there. WDYT |
Yes, I agree with @gaocegege . |
@YujiOshima @gaocegege |
/ok-to-test |
/retest |
@libbyandhelen Please rebase the upstream/master and have a try 😄 |
@YujiOshima PTAL |
I'm going to take a look. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR add random forest as prior to Bayesian Optimization algorithm. RF is more suitable for discrete and categorical parameters, while gaussian process if more suitable for categorical parameters.