Fix worker error silent #863
Conversation
| } | ||
| cmd.Wait() | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we use the third-party tool such as https://github.com/hpcloud/tail?
There was a problem hiding this comment.
How do you signal the completion of tail logs?
There was a problem hiding this comment.
we doesn't need know the completion of tail logs, when the worker container exit, metrics collector main process will start to collect and parse the file, and then exit.
There was a problem hiding this comment.
Just wondering if there is a chance to miss certain worker container logs in this case.
|
Shall we add a failure e2e test to test failed cases? |
Sure, I can try to add one in another PR |
|
Please rebase when #861 is merged |
| @@ -244,7 +244,7 @@ func wrapWorkerContainer(pod *v1.Pod, jobKind, metricsFile string, mc common.Met | |||
| if c.Args != nil { | |||
| args = append(args, c.Args...) | |||
| } | |||
| redirectStr := fmt.Sprintf(" 2>&1 | tee %s", metricsFile) | |||
| redirectStr := fmt.Sprintf("1>%s 2>&1", metricsFile) | |||
There was a problem hiding this comment.
How do we let users know that kubectl logs works on the side car which outputs logs from worker container too? Should we rename the side car container to "logger" or something?
WDYT? @gaocegege @hougangliu
|
/test kubeflow-katib-presubmit |
|
Needs a reabse. |
rebased already. It seems CI starts to strike now again |
|
/test kubeflow-katib-presubmit |
1 similar comment
|
/test kubeflow-katib-presubmit |
|
@gaocegege @johnugeorge |
|
I think we already set it to 3 in test |
ok |
|
/assign @johnugeorge |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
This change is