Adding metric unavailability to events #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @gaocegege |
gaocegege
reviewed
Oct 9, 2019
| r.recorder.Eventf(instance, corev1.EventTypeNormal, JobSucceededReason, eventMsg) | ||
| } else { | ||
| eventMsg := fmt.Sprintf("Metrics are not available for Job %s", deployedJob.GetName()) | ||
| r.recorder.Eventf(instance, corev1.EventTypeWarning, MetricsUnavailableReason, eventMsg) |
There was a problem hiding this comment.
Maybe we could add a condition to show the warning.
|
/lgtm |
1 task
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When job has succeeded without any available metrics, add a warning event notifying that metrics are not available. This will be helpful in debugging
This change is