Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert env for katib-db #899

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Revert env for katib-db #899

merged 1 commit into from
Oct 25, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Oct 25, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@hougangliu
Copy link
Member Author

@gaocegege @johnugeorge this PR is just a temporary fix so that we can build 0.7.0 image. we need investigate further to fix it.
@johnugeorge after this PR builds image, please replace gcr.io/kubeflow-ci/katib/v1alpha3/katib-manager:latest in kubeflow/manifests#563 to check if it works
If it works, please merge this PR and tag katib 0.7.0 images then.

@gaocegege
Copy link
Member

Do you know why it works?

@gaocegege
Copy link
Member

/lgtm
/approve

It is a temp fix for CI in manifests.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0eadfce into kubeflow:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants