Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add katib-cli download command for Mac #93

Merged
merged 2 commits into from
May 26, 2018

Conversation

vinaykakade
Copy link
Contributor

Added the missing command to download katib-cli on mac.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@gaocegege
Copy link
Member

Hi, is there any problem? I think the changes LGTM.

@vinaykakade vinaykakade reopened this May 25, 2018
@googlebot
Copy link

CLAs look good, thanks!

@vinaykakade
Copy link
Contributor Author

Closed this earlier to verify the CLA requirement. Signed the CLA.

I think this is now good to be merged.

@vinaykakade
Copy link
Contributor Author

/assign @YujiOshima @gaocegege

@YujiOshima
Copy link
Contributor

/ok-to-test

@YujiOshima
Copy link
Contributor

/lgtm
@vinaykakade Thanks!

@YujiOshima
Copy link
Contributor

/retest

@YujiOshima
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 49d1bef into kubeflow:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants