-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Empty Trial templates in Katib UI #938
Fix: Empty Trial templates in Katib UI #938
Conversation
/retest |
Welcome back! /retest I do not think we need to update v1alpha2. /lgtm |
/retest |
@andreyvelich i see that UI build fails randomly. Can you take a look at it? |
/retest |
1 similar comment
/retest |
Hi, thank you! :) |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
what is the reason for sudden flakiness in CI? |
@johnugeorge I think it fails on this example https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/file-metricscollector-example.yaml in e2e test |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR:
I did it in v1alpha3 version, should I make changes in v1alpha2 also @johnugeorge @gaocegege ?
This change is