Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Empty Trial templates in Katib UI #938

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Nov 28, 2019

In this PR:

  1. Fixed empty page while clicking on Trial Manifests in the Menu
  2. Fetch Trial templates when opening submit by parameters in NAS page.

I did it in v1alpha3 version, should I make changes in v1alpha2 also @johnugeorge @gaocegege ?


This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

@gaocegege
Copy link
Member

Welcome back!

/retest

I do not think we need to update v1alpha2.

/lgtm

@johnugeorge
Copy link
Member

/retest

@johnugeorge
Copy link
Member

@andreyvelich i see that UI build fails randomly. Can you take a look at it?

@johnugeorge
Copy link
Member

/retest

1 similar comment
@johnugeorge
Copy link
Member

/retest

@andreyvelich
Copy link
Member Author

Welcome back!

/retest

I do not think we need to update v1alpha2.

/lgtm

Hi, thank you! :)

@andreyvelich
Copy link
Member Author

/retest

3 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 2, 2019
@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

what is the reason for sudden flakiness in CI?

@andreyvelich
Copy link
Member Author

@johnugeorge
Copy link
Member

/retest

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e19a06 into kubeflow:master Dec 4, 2019
@andreyvelich andreyvelich deleted the fix-ui-get-trial-template branch September 27, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants