Validate experiment #957
Validate experiment #957
Conversation
|
Can you incorporate #768 (comment) too? |
sure |
|
@johnugeorge @gaocegege PTAL |
| @@ -168,7 +168,7 @@ func UpdateExperimentStatusCondition(collector *ExperimentsCollector, instance * | |||
| return | |||
| } | |||
|
|
|||
| if (instance.Spec.MaxFailedTrialCount != nil) && (failedTrialsCount >= *instance.Spec.MaxFailedTrialCount) { | |||
| if (instance.Spec.MaxFailedTrialCount != nil) && (failedTrialsCount > *instance.Spec.MaxFailedTrialCount) { | |||
There was a problem hiding this comment.
() is no necessary. I can change it if there are some other comments :)
|
Looks good. What are your thoughts on it? @gaocegege @hougangliu |
|
I think we can support it. |
|
In fact, IMO, there are multiple fields we can allow user to edit, such as trial template (multiple fields of the template are reasonable to be edit), objective.goal and so on. But it will expand too many cases. I think it is ok to just make the three fields here editable. For other cases, we suggest user to create another experiment. |
|
We can then attempt it later. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #956
Fixes #768
Special notes for your reviewer:
Release note:
This change is