Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiment_status): Add trial name #986

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Dec 23, 2019

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

This PR added a new field in v1alpha3 Exepriment status, which stores the best trial name.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/assign @johnugeorge @hougangliu

@hougangliu
Copy link
Member

/lgtm
BTW, for observation field, now we only show objective metric and "best" value. in fact, we can add "min", "max", "latest" value for more information like other platform (such as ray), WDYT?

@gaocegege
Copy link
Member Author

We show metrics and parameter assignments. I am not sure if I get your idea. Could you please explain more?

@hougangliu
Copy link
Member

We show metrics and parameter assignments. I am not sure if I get your idea. Could you please explain more?

for example, for now if objective metrics is loss, in experiment or trial status, it show the best loss metrics minimum value like below:

observation:
  metrics:
    - name: loss
       value: 0.0001

we can detail it more for a better viewpoint like ray:

observation:
 metrics:
   - name: loss
     min: 0.0001
     max: 0.1234
     latest: 0.1111

@gaocegege
Copy link
Member Author

Gotcha. SGTM

@hougangliu
Copy link
Member

Gotcha. SGTM

/approve
We can enhance it in other PR

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 133845a into kubeflow:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants