Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate PipelineRun with embedded pipelineSpec and taskSpec #143

Closed
ckadner opened this issue May 8, 2020 · 5 comments · Fixed by #166
Closed

Generate PipelineRun with embedded pipelineSpec and taskSpec #143

ckadner opened this issue May 8, 2020 · 5 comments · Fixed by #166
Labels
kind/feature

Comments

@ckadner
Copy link
Member

ckadner commented May 8, 2020

/kind feature

Description:
Convert the YAML produced by the kfp-tekton compiler:

  • from multiple documents (Conditions, Tasks, Pipeline, PipelineRun) into
  • into a single PipelineRun with embedded pipelineSpec and taskSpecs

This will simply the required work for down-stream integration with the KFP API and KFP UI.

Additional information:

spec:
  pipelineSpec:
    tasks:
    - name: task1
      taskSpec:
        steps:
          ...
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

1 similar comment
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@ckadner ckadner changed the title Generate PipelineRun with embedded pipelineSpec and taskSpec Generate PipelineRun with embedded pipelineSpec and taskSpec May 8, 2020
@ckadner
Copy link
Member Author

ckadner commented May 8, 2020

@afrittoli -- do you know if there are any functional limitations with using embedded pipelineSpec and taskSpec?

We are evaluating if the kfp-tekton compiler could generate one single document including Conditions.

@Tomcli
Copy link
Member

Tomcli commented May 8, 2020

@afrittoli pipelineSpec and taskSpec works well on pipelineRun. However, I couldn't find the conditionSpec in the pipelineRun v1beta1 CRD, is it because conditions are still in v1alpha1 API?

@animeshsingh
Copy link
Collaborator

Is there anything else besides pipelineSpec, taskSpec and conditionSpec ?

@animeshsingh animeshsingh reopened this May 10, 2020
@Tomcli Tomcli mentioned this issue May 19, 2020
Closed
2 tasks
@ckadner ckadner mentioned this issue Jun 1, 2020
Merged
12 tasks
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 1, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
bd23726 
Closes kubeflow#143
@ckadner ckadner mentioned this issue Jun 5, 2020
Closed
4 tasks
@fenglixa fenglixa mentioned this issue Jun 11, 2020
Closed
2 tasks
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 16, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
3bf6234 
Closes kubeflow#143
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 16, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
08ef00b 
Closes kubeflow#143
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 16, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
21c44ce 
Closes kubeflow#143
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 16, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
7ac1ca4 
Closes kubeflow#143
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 16, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
24e57bc 
Closes kubeflow#143
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 17, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
d909d9d 
Closes kubeflow#143
ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 23, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec
4423070 
Closes kubeflow#143
k8s-ci-robot pushed a commit that referenced this issue Jun 24, 2020
@ckadner
PipelineRun with embedded pipelineSpec and taskSpec (#166)
196b822 
* PipelineRun with embedded pipelineSpec and taskSpec

Closes #143

* Preserve empty string default values

* Remove success_condition and failure_condition
@Tomcli Tomcli mentioned this issue Jan 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PipelineRun with embedded pipelineSpec and taskSpec ckadner/kfp-tekton
4 participants
@animeshsingh @Tomcli @ckadner @k8s-ci-robot