Update imagepullsecret and update to v0.13.0 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
animeshsingh
reviewed
Jun 9, 2020
fenglixa
reviewed
Jun 9, 2020
sdk/FEATURES.md
Outdated
| @@ -197,6 +195,5 @@ An exit handler is a component that always executes, irrespective of success or | |||
|
|
|||
| [ParallelFor]: https://github.com/tektoncd/pipeline/issues/2050 | |||
| [VarSub]: https://github.com/tektoncd/pipeline/issues/2322 | |||
There was a problem hiding this comment.
VarSub was also addressed in KFP-tekton, is it?
There was a problem hiding this comment.
VarSub is not resolved, the issue is being redirected to a different one with the same feature requirement. I updated the issue link to the new issue.
ckadner
approved these changes
Jun 9, 2020
|
@Tomcli -- can you address Feng's and Animesh's comments so we can merge this? Thanks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #54
Description of your changes:
sin the spec)Environment tested:
python --version): 3.6.4tkn version): v0.13.0kubectl version): 1.16/etc/os-release):