Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken doc links #361

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Nov 10, 2020

There were several links in our Markdown files which were outdated.

/assign @Tomcli @animeshsingh

sdk/FEATURES.md Outdated Show resolved Hide resolved
sdk/README.md Show resolved Hide resolved
@Tomcli
Copy link
Member

Tomcli commented Nov 10, 2020

overall it looks good to me. Needs to update the link in the above comments.

@ckadner
Copy link
Member Author

ckadner commented Nov 10, 2020

Thanks @Tomcli for your review 👍

@animeshsingh should be good to merge after you give it another look 👀 ?

@ckadner ckadner requested a review from Tomcli November 10, 2020 22:15
@animeshsingh
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, ckadner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [animeshsingh,ckadner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4545ff9 into kubeflow:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants