Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set suitable defaults for JupyterHub service type and make it configurable? #80

Closed
jlewi opened this issue Jan 3, 2018 · 1 comment
Closed

Set suitable defaults for JupyterHub service type and make it configurable? #80

jlewi opened this issue Jan 3, 2018 · 1 comment

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 3, 2018

I think the original configuration of JupyterHub was to automatically create an external load balancer.

Is that the best option?

Maybe we should add parameters to the JupyterHub component and make the service type easily configurable.
@jlewi jlewi mentioned this issue Jan 3, 2018
Merged
@jlewi
Copy link
Contributor Author

jlewi commented Mar 26, 2018

Default is now ClusterIp and this is a parameter.
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/prototypes/all.jsonnet#L13

@jlewi jlewi closed this as completed Mar 26, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
@richardsliu @k8s-ci-robot
Update tf-operator to v1 (kubeflow#80)
8146b4e
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@kevinbache @k8s-ci-robot
added self to google-team.members.txt (kubeflow#80)
119a320 
* added self to google-team.members.txt

* alphabetized name

* added self to org.yaml

* added self to google-team.members.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi