Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ambassador getaddrinfo error logs #1537

Merged

Conversation

sambaiz
Copy link
Member

@sambaiz sambaiz commented Sep 15, 2018

This prevents that appear the following error logs in large quantities

socat[1581671] E getaddrinfo("statsd-sink", "NULL", {1,0,2,17}, {}): Name does not resolve

This error always occurs.
It is hardcoded here in ambassador and it is mismatched so it seems to fail to resolve name.

It may resolve #945 (or it maybe already resolved)


This change is Reviewable

@sambaiz sambaiz changed the title Fix ambassador statsd-exporter service name Prevent ambassador error logs in large quantities Sep 15, 2018
@sambaiz sambaiz changed the title Prevent ambassador error logs in large quantities Prevent ambassador getaddrinfo error logs Sep 15, 2018
@sambaiz
Copy link
Member Author

sambaiz commented Sep 15, 2018

/assign @kunmingg

@kunmingg
Copy link
Contributor

@sambaiz
Can you provide more info in PR description?
When will the error occur and why switch name fix it?
Is there a name mismatch or we hardcode the name somewhere?

Thanks!

@kunmingg
Copy link
Contributor

/ok-to-test

@sambaiz
Copy link
Member Author

sambaiz commented Sep 18, 2018

@kunmingg
This error always occurs.
It is hardcoded here in ambassador and it is mismatched so it seems to fail to resolve name.

@sambaiz
Copy link
Member Author

sambaiz commented Sep 19, 2018

/retest

1 similar comment
@sambaiz
Copy link
Member Author

sambaiz commented Sep 19, 2018

/retest

@sambaiz sambaiz force-pushed the modify_ambassador_sink_service_name branch from 85b8630 to d5b775a Compare September 19, 2018 14:19
@sambaiz
Copy link
Member Author

sambaiz commented Sep 19, 2018

/retest

@kunmingg
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4e7f4ed into kubeflow:master Sep 19, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambassador Version 0.34.0 causing DNS Issues on Worker Node
4 participants