-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Server Component documentation triage. #181
Conversation
elsonrodriguez
commented
Jan 31, 2018
- Made it so that the image created in the instructions is utilizied
- Removed downloaded model due to incompatibility with recent TF server versions
- Made tf-serving image configurable
- Minor flow/grammar tweaks
Hi @elsonrodriguez. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Should I also add an example of using the inception client to the user_guide? |
I thought @nkashy1 already added an example of using the client? |
They did, but in the component documentation, not the user_guide. It's a bit of repetition, but might make things easier to understand. If yes I can do in another PR. |
How about creating an E2E example using inception? Some things that might be demonstrated
Should we centralize all the docs and code specific to inception in one location and avoid duplication? I think everything in components/ should be generic and not be specific (e.g. inception). We could create an examples/inception directory, although I think my preference would be to create a separate repository #174. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elsonrodriguez since @lluunn LGTM'd this I'm happy to merge it once its sync'd and we can follow up in another issue PR regarding a more complete example for inception. |
- Made it so that the image created in the instructions is utilizied - Removed downloaded model due to incompatibility with recent TF server versions - Made tf-serving image configurable - Minor flow/grammar tweaks
832a14d
to
186923e
Compare
@jlewi synced |
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
* Update ci-viewer members Add Dan Sun and Yuzhui Liu * Update ci-viewer.members.txt Use alphabetical order and add Ilan>