Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Server Component documentation triage. #181

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

elsonrodriguez
Copy link
Contributor

  • Made it so that the image created in the instructions is utilizied
  • Removed downloaded model due to incompatibility with recent TF server versions
  • Made tf-serving image configurable
  • Minor flow/grammar tweaks

@k8s-ci-robot
Copy link
Contributor

Hi @elsonrodriguez. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elsonrodriguez
Copy link
Contributor Author

Should I also add an example of using the inception client to the user_guide?

@jlewi jlewi requested review from zomglings and lluunn February 1, 2018 02:26
@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

I thought @nkashy1 already added an example of using the client?

@elsonrodriguez
Copy link
Contributor Author

They did, but in the component documentation, not the user_guide. It's a bit of repetition, but might make things easier to understand.

If yes I can do in another PR.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

How about creating an E2E example using inception? Some things that might be demonstrated

* Generating predictions from outside the cluster (e.g. via secure reverse proxy)
* A web app that can act as a FE [here's](https://github.com/vishh/container-engine-accelerators/tree/example-gpu/example/inception-golang/src) the code used in our demo at Kubecon
 * Clear docs for running the sample

Should we centralize all the docs and code specific to inception in one location and avoid duplication?

I think everything in components/ should be generic and not be specific (e.g. inception). We could create an examples/inception directory, although I think my preference would be to create a separate repository #174.

Copy link
Contributor

@lluunn lluunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

@elsonrodriguez since @lluunn LGTM'd this I'm happy to merge it once its sync'd and we can follow up in another issue PR regarding a more complete example for inception.

- Made it so that the image created in the instructions is utilizied
- Removed downloaded model due to incompatibility with recent TF server versions
- Made tf-serving image configurable
- Minor flow/grammar tweaks
@elsonrodriguez
Copy link
Contributor Author

@jlewi synced

@jlewi jlewi merged commit c85834c into kubeflow:master Feb 2, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
* Update ci-viewer members

Add Dan Sun and Yuzhui Liu

* Update ci-viewer.members.txt

Use alphabetical order and add Ilan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants