Roll out model with istio #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlewi
reviewed
Oct 22, 2018
| "apiVersion: ambassador/v0", | ||
| "kind: Mapping", | ||
| "name: tfserving-predict-mapping-" + modelName, | ||
| "prefix: /tfserving/models/" + modelName, |
There was a problem hiding this comment.
We don't need to address it in this PR; but do we need to have individual rewrite rules for different paths and methods?
Could we just have a single rewrite rule
/tfserving/models/modelName -> /v1/models/
|
This is great. Thanks. /lgtm Can you resolve the conflicts? |
|
test comment |
|
test comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 23, 2018
Closed
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* roll out model with istio * fix test * fix test * fix test * fix test
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* application path update: certmanager, istio, authservice * application path update: certmanager, istio, kfserving, knative * delete deprecated/unused component application path update: namespace, roles, katib, central dashboard * application path update: notebook, tensorboard, mpi, xgboost... * application path update: dex, mxnet, kfp-argo * add kfp-tekton to ibm distribution update oidc appid to create secret for clientId and secret move kubeflow istio resources to own application folder * ibm 1.3 kfdef * change kubeflow istio resources to own applicaiton * add fixed nodeport for istio ingressgateway * Don't overwrite all namespaces to kubeflow * add kfdef for ibm kubeflow 1.3 add dex for single user add oauthservice for dex * add new line at end of file * kfdef reporef name fix * kfdef reporef kustomization fix * add moficodes and pvaneck to IBM distribution owners remove adrian555 from IBM Distribution owners * add kfserving to kfdef * remove duplicate compononet from kfdef * reorder profile component profile crds need to be created before we try to create profile instance Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the service part (model) and the deployment (version) of TF serving.
To serve a model, we should deploy service + deployment as:
Service
Deployment
To rollout the version v2,
/cc @jlewi
related:
#1309
This change is