-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5111: Trim whitespace from custom images #5112
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Hi @ianhellstrom. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/assign @kimwnasptd |
/uncc @prodonjs |
@@ -47,7 +47,7 @@ export class RokJupyterLabSelectorComponent implements OnInit { | |||
} | |||
|
|||
setLabValues(lab: JupyterLab) { | |||
this.parentForm.get("customImage").setValue(lab.image); | |||
this.parentForm.get("customImage").setValue(lab.image.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to use the .strip()
function here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, but I may be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianhellstrom my bad, I got confused for a second and thought this was also python code
@ianhellstrom the changes look good, thanks for the PR! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Trim whitespace for custom image names * Trim whitespace from custom image Co-authored-by: Ian Hellström <ihellstrom@d2iq.com>
* Trim whitespace for custom image names * Trim whitespace from custom image Co-authored-by: Ian Hellström <ihellstrom@d2iq.com>
See: #5111
It trims the whitespace around custom images to avoid pod creation failures. It does so in the backend and Rok template, where
customImage
is explicitly set.Note: I tried running both the frontend and backend on my own machine but could not make it work. Perhaps the instructions for npm and Flask are outdated. I ran Flask in a fresh virtual environment.
NPM:
Flask: