Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add willb to approvers #542

Merged
merged 1 commit into from
Apr 3, 2018
Merged

add willb to approvers #542

merged 1 commit into from
Apr 3, 2018

Conversation

willb
Copy link
Contributor

@willb willb commented Mar 30, 2018

This change is Reviewable

@willb
Copy link
Contributor Author

willb commented Mar 30, 2018

/retest

@jlewi
Copy link
Contributor

jlewi commented Mar 30, 2018

/lgtm
/approve

GPU tests are failing they will be disabled by #547

@willb
Copy link
Contributor Author

willb commented Mar 31, 2018

/retest

@jlewi
Copy link
Contributor

jlewi commented Apr 3, 2018

Tests should be fixed. But you might need to resync.

@willb
Copy link
Contributor Author

willb commented Apr 3, 2018

/retest

@willb
Copy link
Contributor Author

willb commented Apr 3, 2018

@jlewi this is passing after a rebase -- could you lgtm it again when you have a chance?

@jlewi
Copy link
Contributor

jlewi commented Apr 3, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9765993 into kubeflow:master Apr 3, 2018
swiftdiaries pushed a commit to swiftdiaries/kubeflow that referenced this pull request Apr 4, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
* gcp basic auth

* gcp iap

* k8s istio

* remove kubeflow from repos

* remove name

* add comment back to basic auth

* move comment back to gcp_iap

* move comment back to k8s_istio

* remove timestamp

* add zone

* remove status
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Adding manifests for manager rest

* Fix to add new image

* Exclude katib-manager-rest in grep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants