Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Argo manifest to 2.5.0 #1099

Closed
rossella opened this issue Apr 10, 2020 · 10 comments
Closed

Update Argo manifest to 2.5.0 #1099

rossella opened this issue Apr 10, 2020 · 10 comments

Comments

@rossella
Copy link

When using CRI-O, PNS executor fails with "executor error: Failed to determine pid for containerID xxxxxxxxxxxxx: container may have exited too quickly" .
This is due to argoproj/argo-workflows#2095
Updating argo fixes the issue.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.62

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@rossella rossella changed the title Update Argo manifest to 2.7.x Update Argo manifest to 2.5.0 Apr 10, 2020
@rossella
Copy link
Author

We tested in our environment with argo workflow-controller 2.5.0 and argo-ui 2.4.2.
We had to apply the following changes:

  • modify argo/base/custer-role.yaml adding for apiGroups argoproj.io the following resources: cronworkflows and workflowtemplates

Shall we go on and create a PR?

@Gsantomaggio
Copy link
Member

I'd add that we ( I and @rossella ) were thinking to split the current Argo deploy in two sections:

  • argo
  • argo-ui

Since they are two different repositories.
We are already working on it, please let us know what you think about that, so we can prepare the PR.

Thank you

@Gsantomaggio
Copy link
Member

@rossella I think we can close this issue. See kubeflow/pipelines#3537

@stale
Copy link

stale bot commented Jul 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Aug 5, 2020

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Aug 5, 2020
@Ark-kun
Copy link

Ark-kun commented Oct 17, 2020

/reopen
Kubeflow Pipelines does not work well with Argo < 2.4
Some people have issues since they install KFP from Kubeflow and get old Argo version.

@k8s-ci-robot k8s-ci-robot reopened this Oct 17, 2020
@k8s-ci-robot
Copy link
Contributor

@Ark-kun: Reopened this issue.

In response to this:

/reopen
Kubeflow Pipelines does not work well with Argo < 2.4
Some people have issues since they install KFP from Kubeflow and get old Argo version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale stale bot removed the lifecycle/stale label Oct 17, 2020
@solarist
Copy link

solarist commented Oct 26, 2020

Some people have issues since they install KFP from Kubeflow and get old Argo version.

We do too. We have installed a full on-prem installation of 1.1, and still see that the executor image is argoexec:v2.3.0, as well as the one set in the workflow-controller-configmap.

@yanniszark
Copy link
Contributor

yanniszark commented Jan 12, 2021

The work for upgrading Argo is tracked in the Kubeflow Pipelines repo.
kubeflow/pipelines#4553
kubeflow/pipelines#4693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants