added support for registration flow env variable

[maganaluis]

Which issue is resolved by this Pull Request:
Resolves # kubeflow/kubeflow#4889

Description of your changes:

This addresses the support needed to disable the registration flow on issue 4889.

I modified the deployment patch, base kustomization and params.env for /common/centraldashboard to add another environment variable called REGISTRATION_FLOW which by default is set to "true". If the user wants to disable the registration flow they have to modify the definitions for the central-dashboard, add the registration-flow variable and set it to "false".

  - kustomizeConfig:
      overlays:
      - istio
      - application
      parameters:
      - name: userid-header
        value: kubeflow-userid
      - name: registration-flow
        value: "false"
      repoRef:
        name: manifests
        path: common/centraldashboard
    name: centraldashboard

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate-changed-only
  3. make test

[kubeflow-bot]

This change is 

[k8s-ci-robot]

Hi @maganaluis. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maganaluis]

@lalithvaka This PR should address 4889, the documentation should also be pretty straight forward.

[krishnadurai]

/ok-to-test

[krishnadurai]

/assign

[maganaluis]

@krishnadurai one of the tests failed, is there documentation to run them locally?

[krishnadurai]

According to this link it seems that you would have to generate tests by running make generate from within tests folder.

Run make test to verify. Commit the generated unit-tests upstream.

[krishnadurai]

It is documented here: https://github.com/kubeflow/manifests/blob/master/tests/README.md

[maganaluis]

/retest

[maganaluis]

@krishnadurai Thank you for the information, looks like the tests passed, the bot now seems to be waiting for the approval label.

[krishnadurai]

/lgtm

[krishnadurai]

@jlewi can you please approve?

[jlewi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlewi]

If you want this to be in 1.1 you will need to cherry pick it onto the 1.1 branch.

[lalithvaka]

@maganaluis , it appears that you may need to update the image tag to get this pick up your latest changes from kubeflow code

[maganaluis]

@lalithvaka actually because of the switch to kustomize v3 to build the Kubeflow manifests, setting this env variable will vary between platforms. I verified the change is in the 1.1 image v1.1.0-g35d7484a

[lalithvaka]

@maganaluis , does that mean you do not have to explicitly update the image tag in your PR? And we can move forward with the cherry pick pull that I submitted?

[maganaluis]

@lalithvaka Yes the cherry pick can be merged, but configuring the env variable is up to the platform owner. See the new pattern here https://github.com/kubeflow/manifests/tree/master/stacks

[pauljegouic]

tried to change value from true to false in common/centraldashboard/base/params.env, but there is no change on KF.

• it seems that the container config has not been successfully applied.

Need help please, what I am doing wrong ?

[pauljegouic]

@krishnadurai

[maganaluis]

@ifs-pauljegouic Feel free to post your issue on Slack, or ping me there. Check that you have the 1.1 version of the central dashboard image, as well as the registration-flow env variable on the Deployment set to "false".