Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to KFP 1.0.0-rc.3 #1341

Merged
merged 3 commits into from
Jul 5, 2020
Merged

Update to KFP 1.0.0-rc.3 #1341

merged 3 commits into from
Jul 5, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jul 3, 2020

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 3, 2020 •
edited
Loading

/assign @jlewi
Major manifest improvements in rc3:

  • mlpipeline-minio-artifact-secret is contained in minio package and referred to in different deployments
  • kustomization.yaml images field are pushed to lowest level packages, so that when adding overlays on top of it, we don't need to add images field override again.
  • metadata-writer has its own package now, so there's no need to refer to its individual components

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 3, 2020

/cc @rmgogogo

@jlewi
Copy link
Contributor

jlewi commented Jul 5, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9a2fc70 into kubeflow:master Jul 5, 2020
Bobgy added a commit to Bobgy/manifests that referenced this pull request Jul 6, 2020
@Bobgy
Update to KFP 1.0.0-rc.3 (kubeflow#1341)
2cf0ab8 
* updated to kfp 1.0.0-rc.3

* Adapt to kfp 1.0rc3 refactoring

* update test snapshots
@Bobgy Bobgy mentioned this pull request Jul 6, 2020
Merged
1 task
k8s-ci-robot pushed a commit that referenced this pull request Jul 6, 2020
@Bobgy
Cherry pick of "Update to KFP 1.0.0-rc.3 #1341" (#1346)
0c415b9 
* updated to kfp 1.0.0-rc.3

* Adapt to kfp 1.0rc3 refactoring

* update test snapshots
@Bobgy Bobgy deleted the kfp_rc3 branch July 14, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

Assignees

@jlewi jlewi

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bobgy @kubeflow-bot @jlewi @k8s-ci-robot @googlebot