-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade istio to 1.4.10-asm.15 #1412
Conversation
/assign @jlewi |
tests/testdata_gcp_kpt/gcp/Kptfile
Outdated
@@ -11,37 +11,31 @@ openAPI: | |||
setter: | |||
name: gcloud.core.project | |||
value: customerProject | |||
isSet: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the hack/generate-xxx script, but looks like this was automatically removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the changes? You shouldn't need to rerun the generate script; it was a one time deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean I don't need to update the testdata for kpt anymore?
This reverts commit 9523ad4.
Thanks @jlewi! |
@jlewi We missed this for the release. |
Reading the instruction
I don't think this is a blocker to release, because DOS attacks should be protected by IAP already. |
/lgtm @Bobgy Note at this point 1.1.0 has been finalized. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: upgrade istio to 1.4.10-asm.15 * update snapshot * Revert "update snapshot" This reverts commit 9523ad4.
Description of your changes:
I think I recently received a GCP email mentioning there's a vulnerability in some istio version, and we should upgrade to latest.
Checklist:
cd manifests/tests
make generate-changed-only
make test