Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create v1.1.0 Azure Kfdef manifests #1487

Merged
merged 11 commits into from
Sep 2, 2020
Merged

Create v1.1.0 Azure Kfdef manifests #1487

merged 11 commits into from
Sep 2, 2020

Conversation

eedorenko
Copy link

  • KFDef manifest for v1.1 to install on Azure
  • Anonymous envoy filter for Istio-1.6.x

@google-cla google-cla bot added the cla: yes label Aug 13, 2020
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @eedorenko. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eedorenko
Copy link
Author

@berndverst FYI

@berndverst
Copy link
Member

/approve

@berndverst
Copy link
Member

/assign @yanniszark

This is fine from an Azure perspective

yanniszark
yanniszark suggested changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@yanniszark yanniszark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eedorenko! The PR overall looks good, only a minor change.
I would suggest also the following:

  • Add the people responsible for manifests on Azure's side to stacks/azure/OWNERS and kfdef/OWNERS.
  • Update the website instructions accordingly, if necessary.

argo/base_v3/kustomization.yaml Outdated Show resolved Hide resolved
@eedorenko
Copy link
Author

eedorenko commented Aug 29, 2020 •
edited
Loading

Add the people responsible for manifests on Azure's side to stacks/azure/OWNERS and kfdef/OWNERS.
Yes, once they are approved as contributors

Update the website instructions accordingly, if necessary.
Yep. On our list. Once this PR is merged.

@eedorenko eedorenko requested a review from yanniszark August 29, 2020 01:22
@eedorenko eedorenko mentioned this pull request Aug 29, 2020
Merged
@eedorenko
Copy link
Author

@yanniszark done!

@eedorenko
Copy link
Author

/verify-owners

@eedorenko
Copy link
Author

The PR to add Azure owners #1524

@yanniszark
Copy link
Contributor

/verify-owners

@eedorenko
Copy link
Author

/verify-owners
/approve

@eedorenko
Copy link
Author

/verify-owners

@swiftdiaries
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: berndverst, eedorenko, swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21c7d7f into kubeflow:v1.1-branch Sep 2, 2020
@dtzar dtzar deleted the eedorenko/kfdef-azure branch September 5, 2020 02:47
@sudivate sudivate mentioned this pull request Sep 17, 2020
Merged
@berndverst berndverst mentioned this pull request Nov 10, 2020
Closed
k8s-ci-robot pushed a commit that referenced this pull request Nov 12, 2020
@berndverst
Replacement PR for PR #1625 - Azure kfdef manifests for 1.2 and previ…
9412a48 
…ous (#1633)

* Add Azure owners (#1524)

* Create v1.1.0 Azure Kfdef manifests (#1487)

* kfdef for azure

* kfdef for azure

* Axure kfdef

* argo version update

* Owners

* OWNERS

* argo version

* Tickle owners

* Tickle owners

* Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD  (#1576)

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml

* intial kdef

* indentation

* eof

* eof

* eof

* eof

* eof

* adding istio to azure stack

* indentation

* update URI

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml

* placeholder for azure ad  values

* Add overlay to support Azure Database for MySQL (#1587)

* Add readme file

* Add Azure overlay for metadata

* Add azure overlay and readme file

* Changed the default metadata db name to be metadata-db

* Remove duplicated file

* Few edits when proofreading the readme.md

* Adding db name to be optional

* move the overlay to azure stack folder

* using relative path for metadata folder

* Add Azure kfdef 1.2 manifests

* Remove Tensorboard from Azure Stack

* Adding myself as Azure stack approver
k8s-ci-robot pushed a commit that referenced this pull request Nov 13, 2020
@berndverst
Azure stack manifest v1.2 release (#1642)
514d0f2 
* Cherry-Pick 'Azure kfdef manifests for 1.2 and previous (#1633)'

* Add Azure owners (#1524)

* Create v1.1.0 Azure Kfdef manifests (#1487)

* kfdef for azure

* kfdef for azure

* Axure kfdef

* argo version update

* Owners

* OWNERS

* argo version

* Tickle owners

* Tickle owners

* Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD  (#1576)

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml

* intial kdef

* indentation

* eof

* eof

* eof

* eof

* eof

* adding istio to azure stack

* indentation

* update URI

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml

* placeholder for azure ad  values

* Add overlay to support Azure Database for MySQL (#1587)

* Add readme file

* Add Azure overlay for metadata

* Add azure overlay and readme file

* Changed the default metadata db name to be metadata-db

* Remove duplicated file

* Few edits when proofreading the readme.md

* Adding db name to be optional

* move the overlay to azure stack folder

* using relative path for metadata folder

* Add Azure kfdef 1.2 manifests

* Remove Tensorboard from Azure Stack

* Adding myself as Azure stack approver

* Cherry-Pick 'Update azure stack for tests'

* Cherry-Pick 'Add Azure stack tests'

* Add additional Azure test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@yanniszark yanniszark Awaiting requested review from yanniszark

Assignees

@yanniszark yanniszark

@swiftdiaries swiftdiaries

Labels
approved cla: yes lgtm needs-ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eedorenko @kubeflow-bot @k8s-ci-robot @berndverst @yanniszark @swiftdiaries