Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick k8s_istio.v1.1.0 KFDef (#1515) #1540

Merged
merged 1 commit into from
Sep 4, 2020
Merged

cherry-pick k8s_istio.v1.1.0 KFDef (#1515) #1540

merged 1 commit into from
Sep 4, 2020

Conversation

swiftdiaries
Copy link
Member

  • Add missing files for k8s_istio.v1.1.0 KFDef

  • Also removed tensorboard from the KFDef

  • Generate tests

Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#5246

Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@swiftdiaries
Add missing files for k8s_istio.v1.1.0 KFDef (kubeflow#1515)
887f14f 
* Add missing files for k8s_istio.v1.1.0 KFDef

* Also removed tensorboard from the KFDef

* Generate tests
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Sep 2, 2020
@swiftdiaries
Copy link
Member Author

/assign @krishnadurai
/assign @Jeffwan

@swiftdiaries swiftdiaries mentioned this pull request Sep 3, 2020
Closed
@crosvera
Copy link

crosvera commented Sep 3, 2020

@swiftdiaries I tested your changes and I could successfully deploy kubeflow. I had to edit the repos section to point to your repo cause the changes are only there.

@swiftdiaries
Copy link
Member Author

Thanks @crosvera ! I'm hoping to get this merged soon so you can use the config as-is

@crosvera
Copy link

crosvera commented Sep 3, 2020 •
edited
Loading

yeah @swiftdiaries, but I still got the same problem that I mention here kubeflow/kubeflow#5271
best regards

@krishnadurai
Copy link
Contributor

/lgtm

@swiftdiaries
Copy link
Member Author

/approve
Approving this myself because this pertains to the kfctl_k8s_istio config

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 98fa8c8 into kubeflow:v1.1-branch Sep 4, 2020
This was referenced Sep 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnadurai krishnadurai krishnadurai approved these changes

@kkasravi kkasravi Awaiting requested review from kkasravi

Assignees

@Jeffwan Jeffwan

@krishnadurai krishnadurai

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@swiftdiaries @kubeflow-bot @crosvera @krishnadurai @k8s-ci-robot @Jeffwan