Introduce a basic proposals flow for more advanced features #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hugely influenced by the proccess that Octant is following https://github.com/vmware-tanzu/octant/blob/master/CONTRIBUTING.md#proposals Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
google-oss-prow
bot
requested review from
elikatsis,
StefanoFioravanzo and
yanniszark
|
Makes sense @kimwnasptd, I agree! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elikatsis, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving forward we should have a slightly more formal process for evaluating more advanced features and requests. This was triggered by the tests discussion, where we will need to evaluate a lot of details #2099 for an engineering effort.
It will be more efficient for reviewing to have information in a more structured way, when evaluating bigger efforts.
I really liked the approach of VMWare's Octant repo, and that's why the initial iteration is identical. It establishes a slightly more formal process, while still giving a lot of room on the structure. I think it's a good first step and we can further improve as we follow this more.
/cc @elikatsis @StefanoFioravanzo @yanniszark