Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: Use verify=false for the one-liner #2142

Closed
wants to merge 1 commit into from
Closed

readme: Use verify=false for the one-liner #2142

wants to merge 1 commit into from

Conversation

kimwnasptd
Copy link
Member

Refs #2133 (comment)

We should remove the --validate=false flag once kubeflow/pipelines#7311 is merged and the KFP manfiests are updated to include the fix

cc @juliusvonkohout

@kimwnasptd
readme: Use verify=false for the one-liner
2d3d3fa 
Don't verify when applying, due to temporary issue with KFP manifests:
kubeflow#2133

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

It is already merged so you should rather go for a straight fix.

@chensun
Copy link
Member

chensun commented Feb 16, 2022

It is already merged so you should rather go for a straight fix.

Yes, the change was merged and released in KFP 1.8.0: https://github.com/kubeflow/pipelines/releases/tag/1.8.0

@kimwnasptd
Copy link
Member Author

Thanks for the update!

@chensun then does this mean I can also use the newest 1.8.0 tag for KFP? I've been using the 1.8.0-rc.2 in the manifests repo until this point.

@chensun
Copy link
Member

chensun commented Feb 16, 2022

Thanks for the update!

@chensun then does this mean I can also use the newest 1.8.0 tag for KFP? I've been using the 1.8.0-rc.2 in the manifests repo until this point.

Yes, please do test out KFP 1.8.0.

@kimwnasptd
Copy link
Member Author

Closing this PR then, in favor of updating to 1.8.0 tag

@kimwnasptd kimwnasptd closed this Feb 16, 2022
@kimwnasptd kimwnasptd deleted the feature-kimwnasptd-verify-false branch February 16, 2022 12:08
@kimwnasptd kimwnasptd mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanoFioravanzo StefanoFioravanzo Awaiting requested review from StefanoFioravanzo

@yanniszark yanniszark Awaiting requested review from yanniszark

Assignees
No one assigned
Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimwnasptd @juliusvonkohout @chensun