Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync kubeflow training operator manifests v1.5.0 rc.0 #2232

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ This repo periodically syncs all official Kubeflow components from their respect

| Component | Local Manifests Path | Upstream Revision |
| - | - | - |
| Training Operator | apps/training-operator/upstream | [v1.4.0](https://github.com/kubeflow/tf-operator/tree/v1.4.0/manifests) |
| Training Operator | apps/training-operator/upstream | [v1.5.0-rc.0](https://github.com/kubeflow/training-operator/tree/v1.5.0-rc.0/manifests) |
| Notebook Controller | apps/jupyter/notebook-controller/upstream | [v1.5.0](https://github.com/kubeflow/kubeflow/tree/v1.5.0/components/notebook-controller/config) |
| Tensorboard Controller | apps/tensorboard/tensorboard-controller/upstream | [v1.5.0](https://github.com/kubeflow/kubeflow/tree/v1.5.0/components/tensorboard-controller/config) |
| Central Dashboard | apps/centraldashboard/upstream | [v1.5.0](https://github.com/kubeflow/kubeflow/tree/v1.5.0/components/centraldashboard/manifests) |
Expand Down
2,476 changes: 1,704 additions & 772 deletions apps/training-operator/upstream/base/crds/kubeflow.org_mpijobs.yaml

Large diffs are not rendered by default.

2,482 changes: 1,707 additions & 775 deletions apps/training-operator/upstream/base/crds/kubeflow.org_mxjobs.yaml

Large diffs are not rendered by default.

2,543 changes: 1,768 additions & 775 deletions apps/training-operator/upstream/base/crds/kubeflow.org_pytorchjobs.yaml

Large diffs are not rendered by default.

2,476 changes: 1,704 additions & 772 deletions apps/training-operator/upstream/base/crds/kubeflow.org_tfjobs.yaml

Large diffs are not rendered by default.

2,476 changes: 1,704 additions & 772 deletions apps/training-operator/upstream/base/crds/kubeflow.org_xgboostjobs.yaml

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions apps/training-operator/upstream/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ spec:
port: 8081
initialDelaySeconds: 15
periodSeconds: 20
timeoutSeconds: 3
readinessProbe:
httpGet:
path: /readyz
port: 8081
initialDelaySeconds: 5
periodSeconds: 10
initialDelaySeconds: 10
periodSeconds: 15
timeoutSeconds: 3
resources:
limits:
cpu: 100m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ rules:
- apiGroups:
- kubeflow.org
resources:
- mpijobs
- tfjobs
- pytorchjobs
- mxjobs
Expand All @@ -37,6 +38,7 @@ rules:
- apiGroups:
- kubeflow.org
resources:
- mpijobs/status
- tfjobs/status
- pytorchjobs/status
- mxjobs/status
Expand All @@ -55,6 +57,7 @@ rules:
- apiGroups:
- kubeflow.org
resources:
- mpijobs
- tfjobs
- pytorchjobs
- mxjobs
Expand All @@ -66,6 +69,7 @@ rules:
- apiGroups:
- kubeflow.org
resources:
- mpijobs/status
- tfjobs/status
- pytorchjobs/status
- mxjobs/status
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ resources:
- kubeflow-training-roles.yaml
images:
- name: kubeflow/training-operator
newName: public.ecr.aws/j1r0q0g6/training/training-operator
newTag: "174e8813666951ded505daf334a37f60fd50c18d"
newTag: "v1-e1434f6"
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ resources:
- namespace.yaml
images:
- name: kubeflow/training-operator
newName: public.ecr.aws/j1r0q0g6/training/training-operator
newTag: "174e8813666951ded505daf334a37f60fd50c18d"
newTag: "v1-e1434f6"
7 changes: 7 additions & 0 deletions hack/sync-training-operator-manifests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,15 @@ cp $SRC_DIR/manifests $DST_DIR -r

echo "Successfully copied all manifests."

echo "Updating README..."
SRC_TXT="\[.*\](https://github.com/kubeflow/training-operator/tree/.*/manifests)"
DST_TXT="\[$COMMIT\](https://github.com/kubeflow/training-operator/tree/$COMMIT/manifests)"

sed -i "s|$SRC_TXT|$DST_TXT|g" ${MANIFESTS_DIR}/README.md

# DEV: Comment out these commands when local testing
echo "Committing the changes..."
cd $MANIFESTS_DIR
git add apps
git add README.md
git commit -m "Update kubeflow/training-operator manifests from ${COMMIT}"