-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rootless Kubeflow part one (istio-cni) #2455
Merged
Merged
Changes from 30 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c22ca62
Proof of concept
juliusvonkohout 7260176
remove legacy stuff
juliusvonkohout eba9538
Update README.md
juliusvonkohout c98af03
Upgrade istio to 1.18.1
tzstoyanov 2d5d31b
Remove legacy stuff in 1.18
juliusvonkohout f184921
Update istio 1.17.3 documentation and enable patches
juliusvonkohout 64bffe9
restore 1.6 and add knative-local-gateway comment
juliusvonkohout e4c29a2
Update kustomization.yaml
juliusvonkohout b321341
Update disable-debugging.yaml
juliusvonkohout 10b0599
Update kustomization.yaml
juliusvonkohout a14531a
update to istio 1.17.5
juliusvonkohout 213ac99
fix patches
juliusvonkohout 62bae7d
kustomize is unhappy...
juliusvonkohout 2fd015a
one patch per file
juliusvonkohout 11a8ed3
Update istio-ingressgateway-remove-pdb.yaml
juliusvonkohout 773e28e
Update kustomization.yaml
juliusvonkohout f9d3ada
Add istio 1.17.5 CNI installation
tzstoyanov 5751788
delete istio-cni-1-16
juliusvonkohout 9e67d3c
Update disable-debugging.yaml
juliusvonkohout 37e6740
add --set components.cni.enabled=true --set components.cni.namespace=…
juliusvonkohout 4c9a896
add tests for istio-cni
juliusvonkohout 7d1ff92
move PSP and PSS to /contrib
juliusvonkohout 8c51604
Use default CPU resources
tzstoyanov e42b26b
Update README.md
juliusvonkohout e45c674
Do not install istio in one namespace
tzstoyanov bd8f55c
Add github action for Istio CNI testing
tzstoyanov e25b0ef
readd istiod-remove-pdb
juliusvonkohout 124c5cc
we will do /contrib changes in a new PR with capital one
juliusvonkohout f01d9e7
Trigger Istio CNI github action on PR
tzstoyanov 59f3688
Update tests/gh-actions/install_knative-cni.sh
juliusvonkohout a893541
Change the trigger for the Istio CNI github action
tzstoyanov 5fd16d0
Update README.md
juliusvonkohout File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| name: Build & Apply KServe manifests in KinD, using istio CNI | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - contrib/kserve/** | ||
| - common/knative/** | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Install KinD | ||
| run: ./tests/gh-actions/install_kind.sh | ||
|
|
||
| - name: Create KinD Cluster | ||
| run: kind create cluster --config tests/gh-actions/kind-cluster.yaml | ||
|
|
||
| - name: Install kustomize | ||
| run: ./tests/gh-actions/install_kustomize.sh | ||
|
|
||
| - name: Create kubeflow namespace | ||
| run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - | ||
|
|
||
| - name: Install Istio CNI | ||
| run: ./tests/gh-actions/install_istio-cni.sh | ||
|
|
||
| - name: Install cert-manager | ||
| run: ./tests/gh-actions/install_cert_manager.sh | ||
|
|
||
| - name: Install knative CNI | ||
| run: ./tests/gh-actions/install_knative-cni.sh | ||
|
|
||
| - name: Build & Apply manifests | ||
| run: ./tests/gh-actions/install_kserve.sh | ||
|
|
||
| - name: Create test namespace | ||
| run: kubectl create ns kserve-test | ||
|
|
||
| - name: Setup python 3.9 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.9 | ||
|
|
||
| - name: Install test dependencies | ||
| run: pip install -r ./contrib/kserve/tests/requirements.txt | ||
|
|
||
| - name: Port forward | ||
| run: | | ||
| INGRESS_GATEWAY_SERVICE=$(kubectl get svc --namespace istio-system --selector="app=istio-ingressgateway" --output jsonpath='{.items[0].metadata.name}') | ||
| nohup kubectl port-forward --namespace istio-system svc/${INGRESS_GATEWAY_SERVICE} 8080:80 & | ||
|
|
||
| - name: Run kserve tests | ||
| run: | | ||
| export KSERVE_INGRESS_HOST_PORT=localhost:8080 | ||
| cd ./contrib/kserve/tests && pytest . | ||
|
|
||
| - name: Run kserve models webapp test | ||
| run: | | ||
| kubectl wait --for=condition=Available --timeout=300s -n kubeflow deployment/kserve-models-web-app | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a trigger here based on changes to specific directories, not just workflow_dispatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tzstoyanov will check this on monday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this Istio CNI functionality is still experimental and not enabled by default yet, I added only a manual trigger of the github action. However, added also an automatic trigger on every change that uses Istio CNI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the trigger correctly, only people with write access will have access to trigger the workflow based on workflow_dispatch. So, not sure if it's necessary to keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this would be the easiest way to run Istio CNI tests. Lets keep it at least for one release, until Istio CNI is not enabled by default. We can remove the manual trigger at any time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this test be triggered when there is a change to istio-cni-*? Can we trigger the test to ensure it runs successfully?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that makes more sense than the current logic. Changed the trigger action, thanks Anna.