Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update kserve to version 0.11.2 #2616

Conversation

imVipul3000
Copy link

@imVipul3000 imVipul3000 commented Feb 11, 2024

Which issue is resolved by this Pull Request:
Resolves #2572

Description of your changes:
Replace kServe to the version where this issue is fixed.
kserve/kserve#3256

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

Copy link

google-cla bot commented Feb 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: imVipul3000
Once this PR has been reviewed and has the lgtm label, please assign elikatsis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 11, 2024

@kromanow94 this sounds interesting. Do you want to take a look?

I just need someone independent to test before merging.

@juliusvonkohout
Copy link
Member

/retest

@juliusvonkohout
Copy link
Member

@imVipul3000 i cannot se the tag 0.11.2 in https://hub.docker.com/r/kserve/models-web-app/tags

@juliusvonkohout
Copy link
Member

I asked for newer tags in #2603 (comment)

@juliusvonkohout juliusvonkohout changed the title Fix: Updated the kserve to the version 0.11.2 Fix: Update the kserve to the version 0.11.2 Feb 20, 2024
@juliusvonkohout juliusvonkohout changed the title Fix: Update the kserve to the version 0.11.2 Fix: Update kserve to version 0.11.2 Feb 20, 2024
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 20, 2024

Did you really do

upstream-manifests/contrib/kserve$ make
cd kserve && rm -f kserve.yaml kserve-runtimes.yaml kserve_kubeflow.yaml
curl -sSL 'https://github.com/kserve/kserve/releases/download/v0.11.2/kserve_kubeflow.yaml' -o 'kserve/kserve_kubeflow.yaml'
curl -sSL 'https://github.com/kserve/kserve/releases/download/v0.11.2/kserve-runtimes.yaml' -o 'kserve/kserve-runtimes.yaml'
curl -sSL 'https://github.com/kserve/kserve/releases/download/v0.11.2/kserve.yaml' -o 'kserve/kserve.yaml'

and follow the readme.md?

@juliusvonkohout
Copy link
Member

@rimolive wants to take this

@rimolive
Copy link
Member

Closing this issue. Models Webapp is stuck on 0.10 and there's a follow up PR to bump the other images to 0.11.2.

Please follow updates on #2627

@rimolive rimolive closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update the KServe to the version 0.11.2
3 participants