fix most kustomize v5 warnings

[AndersBennedsgaard]

Which issue is resolved by this Pull Request:

Related to #2388

Description of your changes:

Fix most Kustomize v5 warnings related to for common/.
The warning about vars being deprecated is still present for oidc-client/oidc-authservice/base/kustomization.yaml as I weren't successful in fixing it without changes.
kustomize build generates no changes between old and new version.

Checklist:

• Unit tests pass:
  Make sure you have installed kustomize == 5.0.3
  1. make generate-changed-only
  2. make test

[AndersBennedsgaard]

@juliusvonkohout I've merged the PRs into one. As I mentioned in the PR description, I am not sure on how to fix vars being deprecated, so the oidc-authservice still produces a warning about that. And some tests are failing.

[juliusvonkohout]

@AndersBennedsgaard we have commonLabels: in many components. I am not sure whether we should switch partially over to the other method (which i am also using myself). What is your argument for doing so? Maybe it is better to only do the kustomize 5 changes for now.

[juliusvonkohout]

@diegolovison can you verify this on your local cluster?

[juliusvonkohout]

@AndersBennedsgaard patches/clusterrole-patch.yaml is not accepted by kustomize 5 i guess. Can you check how we can have multiple resources in the same file with kustomize 5 ? Maybe there is a new way to have a list of resources in a single file.

[AndersBennedsgaard]

@AndersBennedsgaard we have commonLabels: in many components. I am not sure whether we should switch partially over to the other method (which i am also using myself). What is your argument for doing so? Maybe it is better to only do the kustomize 5 changes for now.

Because commonLabels are marked as deprecated. See kubernetes-sigs/kustomize#5436
commonLabels and labels with includeSelectors=true basically produce the same result, so kustomize edit fix changes it to labels.

[juliusvonkohout]

If common labels is deprecated this is fine. I looked at multiple patches per file and found kubernetes-sigs/kustomize#5049

[AndersBennedsgaard]

@juliusvonkohout should I split the patches into separate files instead then?

[juliusvonkohout]

Maybe we have to upgrade to kustomize 5.3.0 kubernetes-sigs/kustomize#5194
kubernetes-sigs/kustomize#5059 (comment)

[juliusvonkohout]

@juliusvonkohout should I split the patches into separate files instead then?

Try with kustomize 5.3.0 first please. If that works we might just upgrade kustomize

[AndersBennedsgaard]

I am already using 5.3, which works as expected

Edit: it seems to have been fixed in 5.2.1: https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.2.1

[juliusvonkohout]

@rimolive based on the above comments i want to upgrade to kustomize 5.2.1+ and reflect this in the readme as well.

[diegolovison]

If we are going to start support kustomize 5.x.x from this PR, I would like to ask to change:

• https://github.com/kubeflow/manifests/blob/master/tests/gh-actions/install_kustomize.sh
• https://github.com/kubeflow/manifests#prerequisites
• https://github.com/kubeflow/manifests/blob/master/.github/pull_request_template.md

[juliusvonkohout]

#2654 5.2.1 seems to be working with the manifests

[juliusvonkohout]

@kimwnasptd what do you think?

[juliusvonkohout]

If we are going to start support kustomize 5.x.x from this PR, I would like to ask to change:

* https://github.com/kubeflow/manifests/blob/master/tests/gh-actions/install_kustomize.sh

* https://github.com/kubeflow/manifests#prerequisites

* https://github.com/kubeflow/manifests/blob/master/.github/pull_request_template.md

Yes it is in #2654

[rimolive]

@juliusvonkohout Are we good with merging this PR as we moved to 5.2.1?

[AndersBennedsgaard]

@rimolive I think it would be better to hold this until #2654 has been merged, so unit tests can pass.
I also need to update

manifests/common/knative/README.md

Line 40 in 68652a1

gateway. We will make this into a patch once we update kustomize to v4,

[juliusvonkohout]

@AndersBennedsgaard feel free to rebase to master. I merged the other PR.

[AndersBennedsgaard]

I had a couple of git issues, but I think it is fine now. I have tried to add a patch for deleting the Knative-serving gateway as mentioned in the README. Do you think this is the right approach?

[juliusvonkohout]

I might be able to review this on Monday.

[juliusvonkohout]

Sorry for the delay, i probably have to postpone this to next week.

[juliusvonkohout]

The diff seems to be zero

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndersBennedsgaard, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment