Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --kubeconfig mycluster.yaml and use KUBECONFIG instead of moving files #2792

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

diegolovison
Copy link
Contributor

Pull Request Template for Kubeflow manifests Issues

  • Please include a summary of changes and the related issue.
    Improve docs
  • The following checklist will help you to satisfy the requirements.

✏️ A brief description of the changes

I changed the documentation to avoid having extra parameters and moving local files

🐛 If this PR is related to an issue, please put the link of the issue here.

Fixes #2738

✅ Unit Test Checklist

  • [ X ] 🛠️ Make sure you have installed kustomize == 5.2.1+
  • ✍️ Have you written new tests for your core changes, as applicable?
  • 🔄 Have you successfully run existing tests with your changes ?
  • 🚀 Have you successfully run existing and new tests with your changes ?

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

…ng files

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
@juliusvonkohout
Copy link
Member

/lgtm
/approve

since it is from the documentation lead and not harmful

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit da2b718 into kubeflow:master Jul 9, 2024
3 checks passed
hansinikarunarathne pushed a commit to hansinikarunarathne/kubeflow-manifests that referenced this pull request Jul 22, 2024
…ng files (kubeflow#2792)

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing mycluster.yaml
2 participants