-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to change the default username for dex #2810
Conversation
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
I would be eager to know if this is right approach I could undo this to push a newer commit. |
This is for @diegolovison |
Hi @biswajit-9776 thanks for your contribution. I would like to know:
I believe your PR is good to merge as is but having all those things clear in a single PR is even better. |
Hello @diegolovison, this PR is dedicated to default username for dex login as the PR #2777 was for default password. |
/lgtm |
Since it is lgtmed by the documentation lead I |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCO
check)cla/google
check)