Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to change the default username for dex #2810

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

biswajit-9776
Copy link
Contributor

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I documented on how to change default username and email for dex.

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@biswajit-9776
Copy link
Contributor Author

I would be eager to know if this is right approach I could undo this to push a newer commit.

@juliusvonkohout
Copy link
Member

This is for @diegolovison

@diegolovison
Copy link
Contributor

Hi @biswajit-9776 thanks for your contribution.

I would like to know:

  • how can we change the username/email once we have KFP deployed?
  • is is possible to change when we have KFP deployed?
  • Describe the difference between email and username

I believe your PR is good to merge as is but having all those things clear in a single PR is even better.
If you wish to work on the topics above in other PR just let me know.

@biswajit-9776 biswajit-9776 changed the title Documented on how to change default username Documented on how to change default username for dex Jul 22, 2024
@biswajit-9776
Copy link
Contributor Author

biswajit-9776 commented Jul 22, 2024

Hello @diegolovison, this PR is dedicated to default username for dex login as the PR #2777 was for default password.
email is what we fill in when we try to login at the dex dashboard before entering the password.
username is what gets visible in the profile.
Should it reflect KFP in any way?

@juliusvonkohout juliusvonkohout changed the title Documented on how to change default username for dex Document how to change the default username for dex Jul 22, 2024
@diegolovison
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 29, 2024
@juliusvonkohout
Copy link
Member

Since it is lgtmed by the documentation lead I
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f226d30 into kubeflow:master Jul 29, 2024
6 checks passed
hansinikarunarathne pushed a commit to hansinikarunarathne/kubeflow-manifests that referenced this pull request Jul 30, 2024
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants