-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ambient profile installation for istio #2822
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hansinikarunarathne can you help here? We should allow to have multiple yamls in a single file separated by "---"
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
If we can run it in parallel, yes let's do so. |
As I suggested in #2676, I think it would be safer to follow these steps first as a preparation for a move to ambient:
After this, you could commence the move to ambient by identifying the components needing L7 proxies, deploying them and then moving to ambient (profile=ambient). |
Yes, @juliusvonkohout should I migrate to Gateway API in this PR or make another one? |
If it works also with the legacy and istio-cni i prefer a separate PR. |
Yes lets do so. That means
|
Hey @biswajit-9776 @peterj, could you also add instructions in the description of the PR on how to also test this PR? |
Hey @kimwnasptd thanks for hopping in, apologies from my side as I have been working on PSS workflows since last week. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
@juliusvonkohout: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link to the issue here.
#2676
✅ Contributor checklist
DCO
check)cla/google
check)