Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with linting of YAML files #2825

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linting_bash_python_yaml_files.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Proper linting on Bash, Python, and YAML files

on: [pull_request]

Check warning on line 3 in .github/workflows/linting_bash_python_yaml_files.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

3:1 [truthy] truthy value should be one of [false, true]

jobs:
format_python_files:
Expand Down Expand Up @@ -71,7 +71,7 @@
- name: Set up changed files
id: changed_files
run: |
git diff --name-status origin/master...HEAD | grep -E '^[AM].*\.(yaml|yml)$' | awk '{print $2}' > changed_files_in_PR.txt || true
git diff --name-only --diff-filter=AM origin/master...HEAD | grep -E '^common/.*\.ya?ml$|^example/.*\.ya?ml$|^hack/.*\.ya?ml$|^tests/.*\.ya?ml$|^.github/.*\.ya?ml$' > changed_files_in_PR.txt || true
if [ ! -s changed_files_in_PR.txt ]; then
echo "No YAML files have changed in this PR." > changed_files_in_PR.txt
fi
Expand Down Expand Up @@ -125,7 +125,7 @@
fi

- name: Display changed files
if: always() # Always run this step

Check warning on line 128 in .github/workflows/linting_bash_python_yaml_files.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

128:20 [comments] too few spaces before comment
run: cat changed_files_in_PR.txt || echo "No bash files have changed in this PR."

- name: Run ShellCheck on changed files
Expand Down
Loading