-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seaweedfs to contrib #2826
Add seaweedfs to contrib #2826
Conversation
ae55850
to
32d192e
Compare
/ok-to-test |
And first of all thank you very much for the PR. |
This is a follow up of the discussion in kubeflow/pipelines#10998 |
One current problem is getting an artifact via the Artifacts view in the UI. mlpipeline-ui crashes because of a missing region parameter in the js minio client. Not sure why this problem appears when using seaweedfs, because there is no change in configuration there. |
0ac99d3
to
f4eb716
Compare
f4eb716
to
3b15e90
Compare
/ok-to-test |
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
1565802
to
b09fc19
Compare
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Pipeline should succeed now. |
d8c465c
to
3c73156
Compare
…ntrib Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
@pschoen-itsc shall I review this for merging or do you want to continue with the user management in the same PR? Please also check kubeflow/pipelines#10998 (comment). |
You can review this. I think it is better to do the user management in a different PR. |
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
eaabbc5
to
254b6f4
Compare
Somehow https://github.com/kubeflow/manifests/actions/runs/11101539942/job/30958766562 failed. If it fails on the rerun again we have to fix this first before merging. |
Maybe a rebase to master is helpful as well, because some tests and scripts changed with the latest commit yesterday. |
Yes, a rebase is necessary. |
Will do it today. |
…ntrib Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
/lgtm Thank you very much. For the user management we will also need some tests to make sure that they cannot access other users artifacts. We also need to verify that the artifacts work in the UI. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCO
check)cla/google
check)