metadata db in overlay #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use parameter files for db configuration
|
@xaniasd do you know why the tests failed? /assign @zhenghuiwang |
|
/retest |
|
@jlewi not really, haven't spent much time on understanding the CI part so it's a bit cryptic to me. Code (+tests) work on my machine though 😄 I'm running the tests again, hopefully it was just a glitch |
|
@jlewi it was a glitch indeed |
|
/lgtm Thanks @xaniasd ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhenghuiwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Feb 13, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Feb 17, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Mar 4, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Mar 5, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Mar 9, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
1 task
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Apr 14, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Apr 14, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Apr 15, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
discordianfish
added a commit
to discordianfish/kubeflow-manifests
that referenced
this pull request
Apr 27, 2020
similar to kubeflow#673, this allows users to create their own overlay to use external databases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves kubeflow/metadata#171
Description of your changes:
With this PR the metadata-db is deployed as an overlay and not with the base layer. This allows deployments using an external (to Kubeflow) database server to avoid security risks and wasting resources. The default KfDef files are updated to use the overlay; use cases such as the one outlined here must remove the db overlay from KfDef and use a custom overlay to configure the metadata deployment.
Checklist:
cd manifests/testsmake generatemake testThis change is