Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install protoc fails on Fedora 40 #254

Closed
Al-Pragliola opened this issue Aug 9, 2024 · 0 comments · Fixed by #256
Closed

Install protoc fails on Fedora 40 #254

Al-Pragliola opened this issue Aug 9, 2024 · 0 comments · Fixed by #256
Labels
good first issue Good for newcomers

Comments

@Al-Pragliola
Copy link
Contributor

Starting with version 40, Fedora switched to wget2 instead of wget, some of the changes are not backward compatible, one of the changes makes relative paths in -P and -O not handled correctly. This causes the protoc installation script scripts/install_protoc.sh to fail:

wget https://github.com/protocolbuffers/protobuf/releases/download/v24.3/protoc-24.3-linux-x86_64.zip -O /
path/to/model-registry/scripts/../protoc.zip
Internal error: Unexpected relative path: '/path/to/model-registry/scripts/..'

One way to fix this is to resolve the parent directory of the script and use that as the base path for the download:

SCRIPT_PARENT_DIR=$( cd -- "${SCRIPT_DIR}/.." && pwd )

...

wget -q https://github.com/protocolbuffers/protobuf/releases/download/v${VERSION}/protoc-${VERSION}-${OS}-${ARCH}.zip -O "${SCRIPT_PARENT_DIR}/protoc.zip" && \

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants