Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made install_protoc.sh compatible with wget2 #256

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Aug 12, 2024

fixes #254

Description

Switches paths from relative to absolute for wget and any other command that uses it, to make it work with wget and wget2.

How Has This Been Tested?

I tested this on my local machine by running make bin/protoc, and also by building the docker image.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola
Copy link
Contributor Author

cc: @tarilabs

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @Al-Pragliola let's wait for the tests to complete then I believe we can quickly merge this one

@tarilabs
Copy link
Member

tested locally on Mac, working

image

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 86c3630 into kubeflow:main Aug 12, 2024
13 checks passed
@tarilabs tarilabs mentioned this pull request Aug 13, 2024
3 tasks
@Al-Pragliola Al-Pragliola deleted the fix/protoc-script branch August 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install protoc fails on Fedora 40
2 participants