build(deps): bump github.com/testcontainers/testcontainers-go from 0.26.0 to 0.32.0 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/testcontainers/testcontainers-go](https://github.com/testcontainers/testcontainers-go) from 0.26.0 to 0.32.0. - [Release notes](https://github.com/testcontainers/testcontainers-go/releases) - [Commits](testcontainers/testcontainers-go@v0.26.0...v0.32.0) --- updated-dependencies: - dependency-name: github.com/testcontainers/testcontainers-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
andreyvelich,
ckadner,
rareddy,
Tomcli and
zijianjoy
tarilabs
reviewed
Jul 8, 2024
There was a problem hiding this comment.
We likely need:
diff --git a/internal/testutils/test_container_utils.go b/internal/testutils/test_container_utils.go
index 42671550..c3ee82c7 100644
--- a/internal/testutils/test_container_utils.go
+++ b/internal/testutils/test_container_utils.go
@@ -7,6 +7,7 @@ import (
"os"
"testing"
+ "github.com/docker/docker/api/types/container"
"github.com/opendatahub-io/model-registry/internal/ml_metadata/proto"
"github.com/testcontainers/testcontainers-go"
"github.com/testcontainers/testcontainers-go/wait"
@@ -82,13 +83,8 @@ func SetupMLMetadataTestContainer(t *testing.T) (*grpc.ClientConn, proto.Metadat
Env: map[string]string{
"METADATA_STORE_SERVER_CONFIG_FILE": "/tmp/shared/conn_config.pb",
},
- Mounts: testcontainers.ContainerMounts{
- testcontainers.ContainerMount{
- Source: testcontainers.GenericBindMountSource{
- HostPath: wd,
- },
- Target: "/tmp/shared",
- },
+ HostConfigModifier: func(hc *container.HostConfig) {
+ hc.Binds = []string{wd + ":/tmp/shared"}
},
WaitingFor: wait.ForLog("Server listening on"),
}
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
as the problem does not reproduce locally Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
tarilabs
force-pushed
the
dependabot/go_modules/github.com/testcontainers/testcontainers-go-0.32.0
branch
from
e12ee20 to
c882df6
Compare
3 tasks
* fix: bumped csi version to 1.21, which was causing toolchain issues Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: align go version across readme, go.mod versions Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com>
tarilabs
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
thanks @dhirajsb for the contrib
bump of testcontainers lib used in Go test for Integration testing.
refactor use of deprecated code for updated method.
bump of linter version and settings, bump of go mods file to avoid linter crashing.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dependabot
bot
deleted the
dependabot/go_modules/github.com/testcontainers/testcontainers-go-0.32.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/testcontainers/testcontainers-go from 0.26.0 to 0.32.0.
Release notes
Sourced from github.com/testcontainers/testcontainers-go's releases.
... (truncated)
Commits
5fb8f5cchore: use new version (v0.32.0) in modules and examples80e57e1feat: honour go toolchain's verbose flag to print out logs (#2624)306f185Fix issues in BuildImage() (#2626)3f73722docs: indicate version for the Run function (#2627)ee9a148chore: remove duplicated tests for config (#2628)9cd7bcbLog retried errors (#2613)d60fc7cfix: do not use deprecated method in postgres tests (#2623)8e4728bfeat: prepare modules for the new API (#2610)a32fe92chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.1 (#2617)5576778chore(deps): bump peter-evans/slash-command-dispatch from 3.0.2 to 4.0.0 (#2561)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)