Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py: get rid of autogen OAI client docs #197

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Py: get rid of autogen OAI client docs #197

merged 4 commits into from
Jul 18, 2024

Conversation

isinyaaa
Copy link
Contributor

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

tarilabs
tarilabs reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @isinyaaa !

I would prefer to keep the use of .PHONY in makefile for bestpractice in future terms and for consistency with other makefile we are using in the project

otherwise all look good to me already

isinyaaa added 4 commits July 18, 2024 10:55
@isinyaaa
py: add black as dev dependency
a6ebdbc 
Necessary for linting

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa
py: get rid of autogen OAI client docs
61708ff 
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa
OAI: get rid of NextPageToken example
3843818 
This avoids gitleaks warnings.

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa
py: fixup ODH -> Kubeflow
de575da 
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa isinyaaa force-pushed the push-rxztwxtzpzwk branch from a6c6389 to de575da Compare July 18, 2024 13:56
@isinyaaa isinyaaa requested a review from tarilabs July 18, 2024 13:56
tarilabs
tarilabs approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @isinyaaa

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 18, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3f49945 into kubeflow:main Jul 18, 2024
13 of 14 checks passed
@isinyaaa isinyaaa deleted the push-rxztwxtzpzwk branch July 18, 2024 14:25
@tarilabs tarilabs mentioned this pull request Jul 22, 2024
Merged
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
@lampajr
Add autogenerated type asserts for new states (kubeflow#197)
06ea855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@rareddy rareddy Awaiting requested review from rareddy

Assignees

@tarilabs tarilabs

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isinyaaa @tarilabs