Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deploying MR locally on a kind cluster for development #273

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Aug 19, 2024

Description

Adds documentation for running MR backend locally via kind.

How Has This Been Tested?

No code changes, you can follow the guide and see if it works for you if you wish.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to try this out, thanks @alexcreasy !

/lgtm

with the comment below:

clients/ui/bff/docs/dev-guide.md Outdated Show resolved Hide resolved
clients/ui/bff/docs/dev-guide.md Outdated Show resolved Hide resolved
clients/ui/bff/docs/dev-guide.md Outdated Show resolved Hide resolved
clients/ui/bff/docs/dev-guide.md Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 19, 2024
@tarilabs tarilabs removed their assignment Aug 20, 2024
Signed-off-by: Alex Creasy <alex@creasy.dev>
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working for me

@ederign
Copy link
Member

ederign commented Aug 20, 2024

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e596525 into kubeflow:main Aug 20, 2024
11 checks passed
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants