Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gha): prevent race condition on port-forward #485

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Oct 17, 2024

Description

I have added the repeat_until function to wait while the pod rollout is done by kind, enabled the kind load job and made the action more reliable

How Has This Been Tested?

run the deploy_on_kind.sh script locally, debug on CI

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

scripts/deploy_on_kind.sh Outdated Show resolved Hide resolved
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola force-pushed the bugfix/gha-race-condition-python-e2e branch from 59ea895 to db4a729 Compare October 17, 2024 17:27
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
@Al-Pragliola Al-Pragliola marked this pull request as ready for review October 17, 2024 17:36
@google-oss-prow google-oss-prow bot requested a review from tarilabs October 17, 2024 17:36
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thank you very much @Al-Pragliola for jumping on this 🚀

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cc9b33d into kubeflow:main Oct 17, 2024
16 checks passed
@Al-Pragliola Al-Pragliola deleted the bugfix/gha-race-condition-python-e2e branch October 17, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants