-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gha): prevent race condition on port-forward #485
fix(gha): prevent race condition on port-forward #485
Conversation
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
59ea895
to
db4a729
Compare
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic, thank you very much @Al-Pragliola for jumping on this 🚀
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
I have added the repeat_until function to wait while the pod rollout is done by kind, enabled the kind load job and made the action more reliable
How Has This Been Tested?
run the deploy_on_kind.sh script locally, debug on CI
Merge criteria:
DCO
check)