-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py: non-regression of user-feedback flow #546
py: non-regression of user-feedback flow #546
Conversation
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
okay it's a bit weird this passes on CI 🤔 😅 |
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
I think the local failure I was experiencing is due to the fact I got both docker (non-desktop, just docker) and Podman (and Podman Desktop) installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) thanks @tarilabs !
Co-authored-by: Isabella Basso <isabellabdoamaral@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, rareddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
edit: this add a non-regression test based on user feedback
How Has This Been Tested?
make test-e2e
Merge criteria:
DCO
check)If you have UI changes