-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bff): load x-forwarded-access-token in cluster setup #558
Conversation
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Ok, tested and it works flawlesly! Great addition, we now have a working version of the deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lucferbux: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks Eder!
@@ -76,7 +76,10 @@ const callRestJSON = <T>( | |||
|
|||
return fetch(`${host}${path}${searchParams ? `?${searchParams}` : ''}`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's generally better to use the URL api to construct this rather than a string template. You get URL encoding / escaping for free that way.
That said this is a nit so I won't hold the PR up for it :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
load x-forwarded-access-token in cluster setup
Description
In this PR:
How Has This Been Tested?
Merge criteria:
DCO
check)