Handle REST status codes #74
Conversation
isinyaaa
force-pushed
the
rest-status-codes
branch
2 times, most recently
from
a5b2dfa to
04a55ec
Compare
There was a problem hiding this comment.
Thank you @isinyaaa !
I prefer for this PR to consider changing return error codes also for failed conversions like s.converter ... in api_model_registry_service_service.go instead of 500 to return 400 for bad request, as discussed.
I'm not sure I understood internal/server/openapi/error.go modification, per comment below.
The mapping function, can be done in a subsequent PR.
| if errors.Is(err, api.ErrBadRequest) { | ||
| return Response(400, model.Error{Message: err.Error()}), nil | ||
| } | ||
| if errors.Is(err, api.ErrNotFound) { | ||
| return Response(404, model.Error{Message: err.Error()}), nil | ||
| } |
There was a problem hiding this comment.
eventually, there can be a mapping function as discussed which for known-errors will return a Response if mapped or nil, so we can refactor similar code here.
isinyaaa
force-pushed
the
rest-status-codes
branch
from
04a55ec to
b89271c
Compare
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
force-pushed
the
rest-status-codes
branch
from
b89271c to
ae57797
Compare
There was a problem hiding this comment.
Thank you for incorporating required improvements and changes from #74 (review) @isinyaaa
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[pull] main from kubeflow:main
Closes: opendatahub-io/model-registry-bf4-kf#305
Description
This handles REST status codes coming from the server core layer using enums and error unwrapping as introduced in GO 1.13.
How Has This Been Tested?
Tested with httpie and go tests.
Merge criteria: