Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 #76

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 6, 2024

Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 6, 2024
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use protobuf for the grpc communication with the underlying MLMD server

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1a17767 into main May 13, 2024
10 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/google.golang.org/protobuf-1.34.0 branch May 13, 2024 07:00
tarilabs pushed a commit to tarilabs/model-registry that referenced this pull request Jul 1, 2024
* Automation: Model-Registry-Isito-Deployment with ODH
This commit merges a script that will deploy Model-Registry with ODH then runs a rest api to conclude the script.
It intended for use with Openshift-CI.

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>

* Revert to original script.
This commit reverts the script to deply basic model-registry back to it's original. Changes here are needed.

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>

* Revert to original file
This commit reverts to the original file format as specifying opendatahub version is not required

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>

* Creating specific rest script for tls
This commit introduces istio-tls- rest.sh script which is specific to the istio-tls deployment
It adds the certs/ to gitignore
It makes changes to the oci-model-registry-istio-tls-deploy.sh script to point to the correct rest.sh

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>

* Update to gitactions
This commit is to allow the PR to pass the codcov tests

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>

---------

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant