Remove default value for ManagedBy

kubeflow · Oct 7, 2024 · 26d3283 · 26d3283
1 parent 08a3ac8
commit 26d3283
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/pkg/apis/kubeflow/v2beta1/default.go b/pkg/apis/kubeflow/v2beta1/default.go
@@ -53,9 +53,6 @@ func setDefaultsRunPolicy(policy *RunPolicy) {
 	if policy.CleanPodPolicy == nil {
 		policy.CleanPodPolicy = ptr.To(CleanPodPolicyNone)
 	}
-	if policy.ManagedBy == nil {
-		policy.ManagedBy = ptr.To(KubeflowJobController)
-	}
 	// The remaining fields are passed as-is to the k8s Job API, which does its
 	// own defaulting.
 }

diff --git a/pkg/apis/kubeflow/v2beta1/default_test.go b/pkg/apis/kubeflow/v2beta1/default_test.go
@@ -32,7 +32,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 					SlotsPerWorker: ptr.To[int32](1),
 					RunPolicy: RunPolicy{
 						CleanPodPolicy: ptr.To(CleanPodPolicyNone),
-						ManagedBy:      ptr.To(KubeflowJobController),
 					},
 					SSHAuthMountPath:       "/root/.ssh",
 					MPIImplementation:      MPIImplementationOpenMPI,
@@ -49,7 +48,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 						TTLSecondsAfterFinished: ptr.To[int32](2),
 						ActiveDeadlineSeconds:   ptr.To[int64](3),
 						BackoffLimit:            ptr.To[int32](4),
-						ManagedBy:               ptr.To(MultiKueueController),
 					},
 					SSHAuthMountPath:       "/home/mpiuser/.ssh",
 					MPIImplementation:      MPIImplementationIntel,
@@ -64,7 +62,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 						TTLSecondsAfterFinished: ptr.To[int32](2),
 						ActiveDeadlineSeconds:   ptr.To[int64](3),
 						BackoffLimit:            ptr.To[int32](4),
-						ManagedBy:               ptr.To(MultiKueueController),
 					},
 					SSHAuthMountPath:       "/home/mpiuser/.ssh",
 					MPIImplementation:      MPIImplementationIntel,
@@ -81,7 +78,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 						TTLSecondsAfterFinished: ptr.To[int32](2),
 						ActiveDeadlineSeconds:   ptr.To[int64](3),
 						BackoffLimit:            ptr.To[int32](4),
-						ManagedBy:               ptr.To(KubeflowJobController),
 					},
 					SSHAuthMountPath:       "/home/mpiuser/.ssh",
 					MPIImplementation:      MPIImplementationMPICH,
@@ -96,7 +92,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 						TTLSecondsAfterFinished: ptr.To[int32](2),
 						ActiveDeadlineSeconds:   ptr.To[int64](3),
 						BackoffLimit:            ptr.To[int32](4),
-						ManagedBy:               ptr.To(KubeflowJobController),
 					},
 					SSHAuthMountPath:       "/home/mpiuser/.ssh",
 					MPIImplementation:      MPIImplementationMPICH,
@@ -117,7 +112,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 					SlotsPerWorker: ptr.To[int32](1),
 					RunPolicy: RunPolicy{
 						CleanPodPolicy: ptr.To(CleanPodPolicyNone),
-						ManagedBy:      ptr.To(KubeflowJobController),
 					},
 					SSHAuthMountPath:       "/root/.ssh",
 					MPIImplementation:      MPIImplementationOpenMPI,
@@ -144,7 +138,6 @@ func TestSetDefaults_MPIJob(t *testing.T) {
 					SlotsPerWorker: ptr.To[int32](1),
 					RunPolicy: RunPolicy{
 						CleanPodPolicy: ptr.To(CleanPodPolicyNone),
-						ManagedBy:      ptr.To(KubeflowJobController),
 					},
 					SSHAuthMountPath:       "/root/.ssh",
 					MPIImplementation:      MPIImplementationOpenMPI,