Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suspend semantics #504

Closed
Tracked by #507
alculquicondor opened this issue Jan 24, 2023 · 7 comments
Closed
Tracked by #507

Add suspend semantics #504

alculquicondor opened this issue Jan 24, 2023 · 7 comments
Assignees

Comments

@alculquicondor
Copy link
Collaborator

alculquicondor commented Jan 24, 2023

The semantics should be similar to that of k8s Job.

And this will pave the work for the training-operator (kubeflow/training-operator#1519)

@tenzen-y
Copy link
Member

/kind feature

@mimowo
Copy link
Contributor

mimowo commented Jan 25, 2023

/assign

@tenzen-y tenzen-y mentioned this issue Jan 26, 2023
10 tasks
@tenzen-y
Copy link
Member

@mimowo We have completed upgrading the kubernetes dependencies in #502.
It may help you implement suspend semantics.

@mimowo
Copy link
Contributor

mimowo commented Jan 27, 2023

@tenzen-y @alculquicondor you may want to look at the WIP implementation (tested manually) here: #511. Any early feedback is welcome.

@tenzen-y
Copy link
Member

tenzen-y commented Feb 3, 2023

Probably, we can close this issue.

@alculquicondor
Copy link
Collaborator Author

/close

@google-oss-prow
Copy link

@alculquicondor: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants