Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Implement ActiveDeadlineSeconds and BackoffLimit #40

Merged
merged 1 commit into from
May 29, 2019

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 28, 2019

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @wackxu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 79a1e6c0-8149-11e9-b9f1-63f75d62ea26

@wackxu wackxu changed the title WIP Implement ActiveDeadlineSeconds and BackoffLimit Implement ActiveDeadlineSeconds and BackoffLimit May 28, 2019
@wackxu
Copy link
Contributor Author

wackxu commented May 28, 2019

/assign @suleisl2000 @gaocegege for review

@suleisl2000
Copy link
Contributor

/ok-to-test

@suleisl2000
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleisl2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 60209ec into kubeflow:master May 29, 2019
@wackxu wackxu deleted the backoff branch May 29, 2019 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants