Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Sync with tf-operator #41

Merged
merged 4 commits into from
May 30, 2019
Merged

Sync with tf-operator #41

merged 4 commits into from
May 30, 2019

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 29, 2019

/assign @suleisl2000


This change is Reviewable

@k8s-ci-robot
Copy link

@wackxu: GitHub didn't allow me to assign the following users: sulei.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sulei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

Hi @wackxu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gopkg.toml Show resolved Hide resolved
@gaocegege
Copy link
Member

/ok-to-test

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@suleisl2000
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleisl2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wackxu
Copy link
Contributor Author

wackxu commented May 30, 2019

/test kubeflow-mxnet-operator-presubmit

@k8s-ci-robot k8s-ci-robot merged commit c1d89bd into kubeflow:master May 30, 2019
@wackxu wackxu deleted the xxx branch May 30, 2019 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants